-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Fix full table scans for objects, files, tables #1709
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=73716c410738fce206e28e0161e66ef984eb1ac7 |
@@ -806,8 +853,21 @@ def file_create(self, req: tsi.FileCreateReq) -> tsi.FileCreateRes: | |||
return tsi.FileCreateRes(digest=digest) | |||
|
|||
def file_content_read(self, req: tsi.FileContentReadReq) -> tsi.FileContentReadRes: | |||
# Must dedupe files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sorry those are comments that are intended to say that we're performing deduping in the query. I could clarify those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, no it is just a note as to why the query is so wild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments are updated to be more clear now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - functionally sound testing locally
We were scanning the whole clickhouse tables for object, file, and table reads, all the time.
Fix so that we only scan the subset of those tables that we need for the specific project referenced in the user query.
This should speed up W&B production reads from about 3s for object_versions, down to just 20ms in many cases (2 orders of magnitude faster). We should get similar improvements for files and table reads. as well.